[webkit-reviews] review granted: [Bug 63153] SVG root element accepts background color but fails to repaint it : [Attachment 231335] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 63153: SVG root element accepts background color but fails to repaint it
https://bugs.webkit.org/show_bug.cgi?id=63153

Attachment 231335: Patch
https://bugs.webkit.org/attachment.cgi?id=231335&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231335&action=review


> Source/WebCore/rendering/RenderBoxModelObject.cpp:193
> +bool RenderBoxModelObject::calculateHasBoxDecorations() const

I don't like this name. What is being "calculated"? It's not returning a
number.

If you keep this name, then I think it should return void and set
m_hasBoxDecorations, or something like that. I guess it depends on how you are
using it.

> Source/WebCore/rendering/svg/RenderSVGRoot.cpp:240
> +    // SVG outlines are painted during PaintPhaseForeground.
> +    if (paintInfo.phase == PaintPhaseOutline || paintInfo.phase ==
PaintPhaseSelfOutline)
> +	   return;
> +

Is that from the previous patch?