[webkit-reviews] review granted: [Bug 132834] Teach Editor to support more direct replacement of a Node : [Attachment 231325] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 12 14:57:27 PDT 2014


Enrica Casucci <enrica at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 132834: Teach Editor to support more direct replacement of a Node
https://bugs.webkit.org/show_bug.cgi?id=132834

Attachment 231325: Patch v2
https://bugs.webkit.org/attachment.cgi?id=231325&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231325&action=review


Looks good to me. Please make sure all the editing tests are still passing.

> Source/WebCore/editing/ReplaceSelectionCommand.h:46
> +	   IgnoreMailBlockquote = 1 << 6,

No comma at the end of the last one


More information about the webkit-reviews mailing list