[webkit-reviews] review granted: [Bug 132574] clean up ResourceLoadTiming : [Attachment 231322] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 132574: clean up ResourceLoadTiming
https://bugs.webkit.org/show_bug.cgi?id=132574

Attachment 231322: Patch
https://bugs.webkit.org/attachment.cgi?id=231322&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231322&action=review


> Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm:199
> +	   if (timing) {

You actually just create ResourceLoadTiming above, so the null check is
misleading. The right way to do this is to use this idiom:

ResourceLoadTiming* resourceLoadTimingIfExists()
ResourceLoadTiming& resourceLoadTiming()