[webkit-reviews] review granted: [Bug 116856] <svg> with opacity and compositing double-applies its opacity : [Attachment 231316] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 12 13:29:30 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 116856: <svg> with opacity and compositing double-applies its opacity
https://bugs.webkit.org/show_bug.cgi?id=116856

Attachment 231316: Patch
https://bugs.webkit.org/attachment.cgi?id=231316&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231316&action=review


> Source/WebCore/rendering/svg/SVGRenderingContext.cpp:104
> +    float opacity = isRenderingMask || (renderer.hasLayer() &&
renderer.enclosingLayer()->isComposited()) ? 1 : style.opacity();

You should do hasLayer() &&
toRenderLayerModelObject(renderer)->layer()->isComposited()).


More information about the webkit-reviews mailing list