[webkit-reviews] review granted: [Bug 113666] SVG outline property is broken and inefficient : [Attachment 231312] Patch from dino - rebaselined

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 12 13:14:27 PDT 2014


Dean Jackson <dino at apple.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 113666: SVG outline property is broken and inefficient
https://bugs.webkit.org/show_bug.cgi?id=113666

Attachment 231312: Patch from dino - rebaselined 
https://bugs.webkit.org/attachment.cgi?id=231312&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231312&action=review


Lies. This patch is not from me.

> LayoutTests/ChangeLog:8
> +	   Patch by Erik Dahlsroem backported from Blink.

Typo in name.

> Source/WebCore/ChangeLog:8
> +	   Patch by Erik Dahlsroem ackported from Blink.

Ditto. Except two typos in this one.

> Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:339
> +    // finally, paint the outline if any

Nit: period at end of sentence.


More information about the webkit-reviews mailing list