[webkit-reviews] review denied: [Bug 132830] DataDetector UI doesn't update with resize : [Attachment 231311] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 12 12:00:55 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 132830: DataDetector UI doesn't update with resize
https://bugs.webkit.org/show_bug.cgi?id=132830

Attachment 231311: Patch
https://bugs.webkit.org/attachment.cgi?id=231311&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231311&action=review


> Source/WebCore/page/FrameView.cpp:559
> +#if ENABLE(TELEPHONE_NUMBER_DETECTION) && !PLATFORM(IOS)
> +    if (m_frame)
> +	   m_frame->editor().contentsResized();
> +#endif

You should wire this up to any layout, not just resizing.


More information about the webkit-reviews mailing list