[webkit-reviews] review granted: [Bug 132812] Make a few icon database improvements : [Attachment 231276] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 132812: Make a few icon database improvements
https://bugs.webkit.org/show_bug.cgi?id=132812

Attachment 231276: Patch
https://bugs.webkit.org/attachment.cgi?id=231276&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231276&action=review


> ERROR: Source/WebKit2/UIProcess/WebIconDatabase.cpp:312:  Place brace on its
own line for function definitions.  [whitespace/braces] [4]
Stylebot is wrong about this, and the bugzilla has been filed.	But...

> ERROR: Source/WebKit2/UIProcess/WebIconDatabase.cpp:312:  Missing space
before {  [whitespace/braces] [5]
Stylebot is right about this.  For c++ lambas we put a space between the close
paren and the open bracket.

> Source/WebKit2/UIProcess/WebIconDatabase.cpp:311
> +    return API::Data::createWithoutCopying(reinterpret_cast<const unsigned
char*>(sharedBuffer->data()), sharedBuffer->size(),

I didn't know about this - brilliant.