[webkit-reviews] review granted: [Bug 132826] [Win] Correct Cygwin Path Confusion in WebInspectorUI Build : [Attachment 231305] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 12 10:32:09 PDT 2014


Joseph Pecoraro <joepeck at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 132826: [Win] Correct Cygwin Path Confusion in WebInspectorUI Build
https://bugs.webkit.org/show_bug.cgi?id=132826

Attachment 231305: Patch
https://bugs.webkit.org/attachment.cgi?id=231305&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231305&action=review


r=me

> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:79
> +my $python = ($^O =~ /cygwin/) ? "/usr/bin/python" : "python";

Nit: Would be nice to have a more readable for of "$^O". Since off-hand I have
no idea what it means.


More information about the webkit-reviews mailing list