[webkit-reviews] review granted: [Bug 132731] Web Inspector: Restore regionLayoutUpdated event in iOS7 inspector and remove regionOversetChanged : [Attachment 231281] Patch integrating reviewer feedback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 12 10:16:19 PDT 2014


Joseph Pecoraro <joepeck at webkit.org> has granted Radu Stavila
<stavila at adobe.com>'s request for review:
Bug 132731: Web Inspector: Restore regionLayoutUpdated event in iOS7 inspector
and remove regionOversetChanged
https://bugs.webkit.org/show_bug.cgi?id=132731

Attachment 231281: Patch integrating reviewer feedback
https://bugs.webkit.org/attachment.cgi?id=231281&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231281&action=review


r=me

> Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js:193
> +	   nameMap.set("webkitregionlayoutupdate", "Region Layout Update");   
/* COMPATIBILITY (iOS 7): regionLayoutUpdated was removed and replaced by
regionOversetChanged */

Style: This should be a single line comment, and should end in a period. We try
not to use multiline comments.

> Source/WebInspectorUI/UserInterface/Protocol/CSSObserver.js:66
> +    /* COMPATIBILITY (iOS 7): regionLayoutUpdated was removed and replaced
by regionOversetChanged */

Style: This should be a single line comment, and should end in a period. We try
not to use multiline comments.


More information about the webkit-reviews mailing list