[webkit-reviews] review granted: [Bug 131104] [EFL] TLSErrors do not cause page load to fail when not ignored : [Attachment 230984] patch - unit test only
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 12 04:58:06 PDT 2014
Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Peter Molnar
<pmolnar.u-szeged at partner.samsung.com>'s request for review:
Bug 131104: [EFL] TLSErrors do not cause page load to fail when not ignored
https://bugs.webkit.org/show_bug.cgi?id=131104
Attachment 230984: patch - unit test only
https://bugs.webkit.org/attachment.cgi?id=230984&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230984&action=review
LGTM except for a trivial naming nit.
> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:44
> +WTF::CString http_uri;
Please don't use _ in variable name. httpUri is ok to me.
More information about the webkit-reviews
mailing list