[webkit-reviews] review denied: [Bug 126460] [CSS Regions] Improve RenderFlowThread::repaintRectangleInRegions() to avoid loop over all the regions : [Attachment 221299] Patch

[bugzilla-daemon at webkit.org]

Andrei Bucur <abucur at adobe.com> has denied Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 126460: [CSS Regions] Improve RenderFlowThread::repaintRectangleInRegions()
to avoid loop over all the regions
https://bugs.webkit.org/show_bug.cgi?id=126460

Attachment 221299: Patch
https://bugs.webkit.org/attachment.cgi?id=221299&action=review

------- Additional Comments from Andrei Bucur <abucur at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221299&action=review


> Source/WebCore/rendering/RenderFlowThread.cpp:441
> +	   // If no regions intersect the repaint rect, it is in the flow
thread overflow.

Unfortunately things are a bit more complex now that content can overflow any
region. Imagine the case of two regions and the first region has a really tall
video inside it, overflowing the first region. The controls will be at the
bottom of the video. If you want to repaint them, the rectangle will
"geometrically" fit inside the second region. However, because the video is
unsplittable it is rendered inside the first region. So basically you will ask
the second region to do the repaint when actually the first region should do
it.

Such a change should also take into account the originating box or the region
range of the box. This is also really tricky to do because it means we should
trigger a repaint when the range of a box changes. I don't think there's an
easy way to implement this optimization :(.