[webkit-reviews] review granted: [Bug 132805] Need function to copy favicon data without image conversion. : [Attachment 231264] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gordon Sheridan
<gordon_sheridan at apple.com>'s request for review:
Bug 132805: Need function to copy favicon data without image conversion.
https://bugs.webkit.org/show_bug.cgi?id=132805

Attachment 231264: Patch
https://bugs.webkit.org/attachment.cgi?id=231264&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231264&action=review


> Source/WebKit2/UIProcess/API/C/WKIconDatabase.cpp:77
> +    WebCore::Image *image =
toImpl(iconDatabaseRef)->imageForPageURL(toWTFString(pageURL));

Formatted wrong. Should be Image* rather than Image * with a space.

> Source/WebKit2/UIProcess/API/C/WKIconDatabase.cpp:79
> +	   return 0;

Should be nullptr.

> Source/WebKit2/UIProcess/API/C/WKIconDatabase.cpp:81
> +    WebCore::SharedBuffer *iconData = image->data();

Formatted wrong. Should be SharedBuffer* rather than SharedBuffer * with a
space.