[webkit-reviews] review denied: [Bug 132800] Clean up CrossThreadTask : [Attachment 231253] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 11 11:12:09 PDT 2014


Darin Adler <darin at apple.com> has denied Zan Dobersek <zandobersek at gmail.com>'s
request for review:
Bug 132800: Clean up CrossThreadTask
https://bugs.webkit.org/show_bug.cgi?id=132800

Attachment 231253: Patch
https://bugs.webkit.org/attachment.cgi?id=231253&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is a fine simplification, but I think we should go even further. I don’t
think we want to use CrossThreadCopier. Instead we should have lambdas for each
of these and copy the arguments explicitly at the call site. Need a new patch
that compiles, though. EWS shows this failing to compile on most platforms.


More information about the webkit-reviews mailing list