[webkit-reviews] review requested: [Bug 132755] WebKit2 on iOS needs to capture the main thread's floating point environment : [Attachment 231257] the patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 11 01:16:47 PDT 2014


Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 132755: WebKit2 on iOS needs to capture the main thread's floating point
environment
https://bugs.webkit.org/show_bug.cgi?id=132755

Attachment 231257: the patch.
https://bugs.webkit.org/attachment.cgi?id=231257&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
This patch has been tested on:
1. OSX x86_64 running the layout tests
2. The iOS simulator running modified versions of the 2 regression tests served
up by a web server.
3. an ARMv7 iOS build running modified versions of the 2 regression tests
served up by a web server.

Before this fix, the iOS simulator would crash, and the ARMv7 iOS run would
yield the wrong answer for the js/floating-point-denormalized.html test.  With
this fix, the iOS simulator no longer crashes, and the ARMv7 run produces the
correct answer.


More information about the webkit-reviews mailing list