[webkit-reviews] review granted: [Bug 131364] WinCairo crashes on acid3 test : [Attachment 231236] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 10 15:33:52 PDT 2014


Brent Fulgham <bfulgham at webkit.org> has granted peavo at outlook.com's request for
review:
Bug 131364: WinCairo crashes on acid3 test
https://bugs.webkit.org/show_bug.cgi?id=131364

Attachment 231236: Patch
https://bugs.webkit.org/attachment.cgi?id=231236&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231236&action=review


Nice work tracking this down! Thank you for all your help. R=me.

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:536
> +		   String url = job->firstRequest().url().string();

This should be a const reference to avoid making an extra copy.


More information about the webkit-reviews mailing list