[webkit-reviews] review denied: [Bug 132574] clean up ResourceLoadTiming : [Attachment 231195] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 132574: clean up ResourceLoadTiming
https://bugs.webkit.org/show_bug.cgi?id=132574

Attachment 231195: Patch
https://bugs.webkit.org/attachment.cgi?id=231195&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231195&action=review


> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:702
> +    ResourceLoadTiming* timing = resourceResponse.resourceLoadTiming();
> +    bool hasResourceLoadTiming = timing;
> +    encoder << hasResourceLoadTiming;
> +    if (hasResourceLoadTiming) {
> +	   encoder << timing->domainLookupStart;
> +	   encoder << timing->domainLookupEnd;
> +	   encoder << timing->connectStart;
> +	   encoder << timing->connectEnd;
> +	   encoder << timing->requestStart;
> +	   encoder << timing->responseStart;
> +	   encoder << timing->secureConnectionStart;
> +    }

This should probably be wrapped in an #if ENABLE(WEB_TIMING).

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:785
> +    bool hasResourceLoadTiming;
> +    if (!decoder.decode(hasResourceLoadTiming))
> +	   return false;
> +    if (hasResourceLoadTiming) {
> +	   response.setResourceLoadTiming(ResourceLoadTiming::create());
> +	   ResourceLoadTiming* timing = response.resourceLoadTiming();
> +	   if (!decoder.decode(timing->domainLookupStart)
> +	       || !decoder.decode(timing->domainLookupEnd)
> +	       || !decoder.decode(timing->connectStart)
> +	       || !decoder.decode(timing->connectEnd)
> +	       || !decoder.decode(timing->requestStart)
> +	       || !decoder.decode(timing->responseStart)
> +	       || !decoder.decode(timing->secureConnectionStart))
> +	       return false;
> +    }

This should probably be wrapped in an #if ENABLE(WEB_TIMING).