[webkit-reviews] review granted: [Bug 132770] [Mac] [iOS] Underlines are too low : [Attachment 231215] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 132770: [Mac] [iOS] Underlines are too low
https://bugs.webkit.org/show_bug.cgi?id=132770

Attachment 231215: Patch
https://bugs.webkit.org/attachment.cgi?id=231215&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231215&action=review


> Source/WebCore/rendering/InlineTextBox.cpp:1015
> +    float textDecorationThickness = roundf(fontSizeScaling);

Seems really strange to “round a scaling”; why do strokes need to be integers?
Wouldn’t the pixel ratio have something to do with the rounding we want to do,
rather than just integer boundaries. Rationale might be helpful.

Is it really OK to round the thickness down to 0 if the font size is <1/2 the
size of the text decoration base font size?

I think getting rid of the fontSizeScaling local would be helpful, since it
would be incorrect to use that value in the code below.