[webkit-reviews] review granted: [Bug 132207] REGRESSION (r167818): editing/inserting/typing-space-to-trigger-smart-link.html fails on WebKit1 bots : [Attachment 231199] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jon Honeycutt
<jhoneycutt at apple.com>'s request for review:
Bug 132207: REGRESSION (r167818):
editing/inserting/typing-space-to-trigger-smart-link.html fails on WebKit1 bots
https://bugs.webkit.org/show_bug.cgi?id=132207

Attachment 231199: Patch
https://bugs.webkit.org/attachment.cgi?id=231199&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231199&action=review


> Source/WebCore/editing/ApplyStyleCommand.cpp:816
>      for (size_t i = 0; i < runs.size(); i++) {
> -	   removeConflictingInlineStyleFromRun(style, runs[i].start,
runs[i].end, runs[i].pastEndNode);
> -	   runs[i].positionForStyleComputation =
positionToComputeInlineStyleChange(runs[i].start, runs[i].dummyElement);
> +	   InlineRunToApplyStyle& run = runs[i];

The better way to write this is:

    for (auto& run : runs) {