[webkit-reviews] review granted: [Bug 132763] Update availability macros : [Attachment 231203] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 132763: Update availability macros
https://bugs.webkit.org/show_bug.cgi?id=132763

Attachment 231203: Patch
https://bugs.webkit.org/attachment.cgi?id=231203&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231203&action=review


The script phases should run when installing headers, and I think the WebKit
target currently doesn’t have INSTALLHDRS_SCRIPT_PHASE set to YES. You’ll need
to add that to WebKit.xcconfig.

> Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:7663
> +				1A1D2115191D96380001619F /* Rewrite
Availability Macros In Framework Headers */,

“in”

> Source/WebKit2/mac/rewrite-availability-macros.sh:3
> +

You should check the build action here and only do this in build, install and
installhdrs.