[webkit-reviews] review granted: [Bug 128985] WebGL EXT_shader_texture_lod may be implemented : [Attachment 231192] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 128985: WebGL EXT_shader_texture_lod may be implemented
https://bugs.webkit.org/show_bug.cgi?id=128985

Attachment 231192: Patch
https://bugs.webkit.org/attachment.cgi?id=231192&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231192&action=review


> Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:140
> +	   // Enable support in ANGLE (if not enabled already)

Nit: missing period.

> LayoutTests/ChangeLog:14
> +	   * webgl/conformance/extensions/ext-shader-texture-lod-expected.txt:
Added.
> +	   * webgl/conformance/extensions/ext-shader-texture-lod.html: Added.
> +	   *
webgl/resources/webgl_test_files/conformance/extensions/ext-shader-texture-lod.
html: Added.

Since this test isn't (yet) part of the official test suite, I think it should
go in fast/canvas/webgl.

Otherwise we're likely to overwrite it if merge tests from Khronos.