[webkit-reviews] review granted: [Bug 132721] JSDOMWindow should have a WatchpointSet to fire on window close : [Attachment 231177] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 132721: JSDOMWindow should have a WatchpointSet to fire on window close
https://bugs.webkit.org/show_bug.cgi?id=132721

Attachment 231177: Patch
https://bugs.webkit.org/attachment.cgi?id=231177&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231177&action=review


> Source/JavaScriptCore/bytecode/PolymorphicGetByIdList.h:84
>      bool doesCalls() const { return type() == Getter || type() ==
CustomGetter; }
> +    bool isWatched() const { return type() == WatchedStub; }

Add an isSimple() and assert that instead of the places where we currently
assert !doesCalls().