[webkit-reviews] review granted: [Bug 132746] TelephoneNumberOverlayControllerMac doesn't handle tiled drawing properly : [Attachment 231175] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 132746: TelephoneNumberOverlayControllerMac doesn't handle tiled drawing
properly
https://bugs.webkit.org/show_bug.cgi?id=132746

Attachment 231175: Patch
https://bugs.webkit.org/attachment.cgi?id=231175&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231175&action=review


>
Source/WebKit2/WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:10
2
> +	   // Don't give the tile rect to the highlight drawing function. It
will try to be smart and place the data detector arrow on
> +	   // the left side of the highlight if we happen to cross a tile
boundary. Instead, allow it to draw over the whole frame bounds,
> +	   // and allow the context clipping to limit the drawing to the region
we want to see.

I don't think this comment is necessary. It explains why you fix this bug, but
I don't think it adds value for the future.