[webkit-reviews] review granted: [Bug 132743] Rename WebKit2.framework to WebKit.framework : [Attachment 231160] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 132743: Rename WebKit2.framework to WebKit.framework
https://bugs.webkit.org/show_bug.cgi?id=132743

Attachment 231160: Patch
https://bugs.webkit.org/attachment.cgi?id=231160&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231160&action=review


> Source/WebKit2/Configurations/WebKit2.xcconfig:27
> +INFOPLIST_FILE = mac/WebKit2.plist;

Let’s call this Info-WebKit2.plist

> Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:45

> +		   CFBundleRef webKit2Bundle =
CFBundleGetBundleWithIdentifier(CFSTR("com.apple.WebKit"));

Let’s rename this to webKitBundle.

> Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:92
> +    NSBundle *webKit2Bundle = [NSBundle
bundleWithIdentifier:@"com.apple.WebKit"];

webKitBundle

> Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:8005
> +				WebKit2.xcodeproj,

Strange

> Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:9277
> +				VERSION_INFO_PREFIX = "";

Can we get rid of this?

> ChangeLog:13
> +	   * WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target
WebProcess).xcscheme:
> +	   Ditto.

There’s another shared scheme to update here.