[webkit-reviews] review granted: [Bug 132718] com.apple.iphonesimulator.=?UTF-8?Q?startSession=20needs=20to=20pass=20=E2=80=9CruntimeIdentifier=E2=80=9D=20?=: [Attachment 231118] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 132718: com.apple.iphonesimulator.startSession needs to pass
“runtimeIdentifier”
https://bugs.webkit.org/show_bug.cgi?id=132718

Attachment 231118: Patch
https://bugs.webkit.org/attachment.cgi?id=231118&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231118&action=review


r=me

>
Tools/DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimu
latorNotification.pm:204
> -    my $userInfo = NSMutableDictionary->dictionaryWithCapacity_(4);
> -    for my $property (qw(applicationArguments applicationEnvironment
applicationIdentifier applicationPath deviceFamily deviceInfo productType
sessionOwner sessionUUID sdkRoot version waitForDebugger)) {
> -	   if (exists $dict->{$property}) {
> -	       my $key = NSString->stringWithCString_($property);
> -	       my $value = $dict->{$property};
> -	       $userInfo->setObject_forKey_($value, $key);
> -	   }
> +    my $userInfo =
NSMutableDictionary->dictionaryWithCapacity_(scalar(keys($dict)) + 1);
> +    foreach my $key (keys($dict)) {
> +	   $userInfo->setObject_forKey_($dict->{$key}, $key);

Nice!