[webkit-reviews] review granted: [Bug 132726] [iOS][WK2] Set up the resize events : [Attachment 231131] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 132726: [iOS][WK2] Set up the resize events
https://bugs.webkit.org/show_bug.cgi?id=132726

Attachment 231131: Patch
https://bugs.webkit.org/attachment.cgi?id=231131&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231131&action=review


This is so tricky that it really demands test coverage; we need to figure out
how to test this in an automated way. I’m really concerned that we will break
this in the future.

> Source/WebCore/WebCore.exp.in:2451
> +__ZN7WebCore9FrameView27setCustomSizeForResizeEventENS_7IntSizeE

Should run the sort-export-file script. I’m pretty sure that this will sort
lower in the file, because it’s a literal ASCII sort, so 9F will come after 10.


> Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:54
> +	   ,
m_isChangingObscuredInsetsInteractively(isChangingObscuredInsetsInteractively)

We want to initialize this to false above in the default constructor too.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2039
> +   
frameView.setCustomSizeForResizeEvent(roundedIntSize(unobscuredContentRectSizeI
nContentCoordinates));

I worry about the use of rounded in all the various cases like this, but I
suppose it’s not new. Is rounding correct as opposed to ceiling or floor?