[webkit-reviews] review granted: [Bug 132685] REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary : [Attachment 231144] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 9 09:31:14 PDT 2014


Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 132685: REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built
in the same binary
https://bugs.webkit.org/show_bug.cgi?id=132685

Attachment 231144: Patch
https://bugs.webkit.org/attachment.cgi?id=231144&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231144&action=review


> Tools/TestWebKitAPI/PlatformGTK.cmake:107
> +add_test(TestWebKit2
${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2/TestWebKit2)
> +set_tests_properties(TestWebKit2 PROPERTIES TIMEOUT 60)
> +set_target_properties(TestWebKit2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY
${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2)

We don't actually need these lines since we don't use the CMake's 'make test.'


More information about the webkit-reviews mailing list