[webkit-reviews] review denied: [Bug 132731] Web Inspector: Restore regionLayoutUpdated event in iOS7 inspector and remove regionOversetChanged : [Attachment 231140] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied Radu Stavila
<stavila at adobe.com>'s request for review:
Bug 132731: Web Inspector: Restore regionLayoutUpdated event in iOS7 inspector
and remove regionOversetChanged
https://bugs.webkit.org/show_bug.cgi?id=132731

Attachment 231140: Patch
https://bugs.webkit.org/attachment.cgi?id=231140&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231140&action=review


Looking good. We can reuse the new path internally. The observer change and
event name map are really the only changes needed.

> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:61
> +    RegionLayoutUpdated: "dom-tree-manager-region-layout-updated",  /*
COMPATIBILITY (iOS 7 and Safari 7): regionLayoutUpdated was removed and
replaced by regionOversetChanged */

Only iOS has compatibility concerns. Safari on OS X always has a matching
WebKit.

We can reuse the new event internally. The only compatibility layer needed is
in the Observer file.

> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:620
> +    /* COMPATIBILITY (iOS 7 and Safari 7): regionLayoutUpdated was removed
and replaced by regionOversetChanged */

Ditto.

> Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js:193
> +	   nameMap.set("webkitregionlayoutupdate", "Region Layout Update");   
/* COMPATIBILITY (iOS 7 and Safari 7): regionLayoutUpdated was removed and
replaced by regionOversetChanged */

This is needed.

> Source/WebInspectorUI/UserInterface/Protocol/CSSObserver.js:67
> +    regionLayoutUpdated: function(namedFlow)

And this is needed. But it can just regionOversetChanged.