[webkit-reviews] review canceled: [Bug 131831] [EFL][WK2] Changing page zoom factor does not work correctly if fixed layout is used. : [Attachment 230568] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has canceled EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 131831: [EFL][WK2] Changing page zoom factor does not work correctly if
fixed layout is used.
https://bugs.webkit.org/show_bug.cgi?id=131831

Attachment 230568: Patch
https://bugs.webkit.org/attachment.cgi?id=230568&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230568&action=review


> Source/WebKit2/UIProcess/WebPageProxy.cpp:3119
> +	   newSize.scale(1 / m_pageZoomFactor);

As mentioned in comment #6, RenderView::viewWidth/Height() multiplies the
pageZoomFactor(= effectiveZoom()) with width/height when fixed layout is
enabled. So, I think we need to check if the calculation logic is correct from
EFL port perspective. I think this patch looks a workaround patch. I'd like to
clear r?,cq? until finishing the investigation.