[webkit-reviews] review granted: [Bug 132721] JSDOMWindow should have a WatchpointSet to fire on window close : [Attachment 231121] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 132721: JSDOMWindow should have a WatchpointSet to fire on window close
https://bugs.webkit.org/show_bug.cgi?id=132721

Attachment 231121: Patch
https://bugs.webkit.org/attachment.cgi?id=231121&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231121&action=review


r=me

> Source/JavaScriptCore/jit/Repatch.cpp:334
> +    if (watchpointSet)
> +	   watchpointSet->add(stubInfo.addWatchpoint(codeBlock));
> +

Is this really the only place we'll ever specialize a window object property
access? Is there some kind of struct flag to guarantee that? For example, what
prevents the DFG from fully inlining the property access?

> Source/WebCore/bindings/js/JSDOMWindowBase.cpp:275
> +    clientData->getAllWorlds(wrapperWorlds);

If DOMWindow were ScriptWrappable, you would need a special case to clear its
inline wrapper. But it isn't. So yay!