[webkit-reviews] review granted: [Bug 132715] Multiple (stacked) cues when shuttling through video while playing closed captions : [Attachment 231126] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 132715: Multiple (stacked) cues when shuttling through video while playing
closed captions
https://bugs.webkit.org/show_bug.cgi?id=132715

Attachment 231126: Patch
https://bugs.webkit.org/attachment.cgi?id=231126&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231126&action=review


> Source/WebCore/html/track/TextTrackCueGeneric.cpp:159
> +    // Do not call the parent class isEqual here, because we are not
cueType() == VTTCue,
> +    // and will fail that equality test.
>      if (!TextTrackCue::isEqual(cue, match))
>	   return false;

Thanks for the explanation. I think this is the best solution for now.