[webkit-reviews] review denied: [Bug 128985] WebGL EXT_shader_texture_lod may be implemented : [Attachment 231094] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 128985: WebGL EXT_shader_texture_lod may be implemented
https://bugs.webkit.org/show_bug.cgi?id=128985

Attachment 231094: Patch
https://bugs.webkit.org/attachment.cgi?id=231094&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231094&action=review


We definitely need a test. There is nothing in the official testsuite :(
This means you'll have to write something from scratch. For now, copy the
existing approach in LayoutTests/webgl and we'll submit the test to khronos
when done.

And yes, we have the ANGLE fixes.

> Source/WebCore/ChangeLog:12
> +	   * WebCore.vcxproj/WebCore.vcxproj:

Don't we also add to the .filters file?

> Source/WebCore/CMakeLists.txt:2941
>  list(APPEND WebCore_SOURCES
> +    platform/text/TextCodecICU.cpp
> +    platform/text/TextEncodingDetectorICU.cpp
>      platform/text/icu/UTextProvider.cpp
>      platform/text/icu/UTextProviderLatin1.cpp
>      platform/text/icu/UTextProviderUTF16.cpp
> -    platform/text/TextCodecICU.cpp
> -    platform/text/TextEncodingDetectorICU.cpp
>  )

Was this intentional?