[webkit-reviews] review granted: [Bug 132683] [Win] Crash when enabling DFG JIT. : [Attachment 231070] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 8 16:07:12 PDT 2014


Geoffrey Garen <ggaren at apple.com> has granted peavo at outlook.com's request for
review:
Bug 132683: [Win] Crash when enabling DFG JIT.
https://bugs.webkit.org/show_bug.cgi?id=132683

Attachment 231070: Patch
https://bugs.webkit.org/attachment.cgi?id=231070&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me

It's kind of a shame that an enum aliases to void* -- that's pretty easy to get
wrong.

Perhaps you can fix this in a follow-up patch by changing the void* inputs to
ImmPtr inputs, or similar.

I think you should pursue a follow-up patch that changes void* input to


More information about the webkit-reviews mailing list