[webkit-reviews] review granted: [Bug 132698] [MSE][Mac] Move AVStreamDataParser off-main-thread. : [Attachment 231089] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 8 12:38:23 PDT 2014


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 132698: [MSE][Mac] Move AVStreamDataParser off-main-thread.
https://bugs.webkit.org/show_bug.cgi?id=132698

Attachment 231089: Patch
https://bugs.webkit.org/attachment.cgi?id=231089&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231089&action=review


>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:496
> +    RefPtr<SourceBufferPrivateAVFObjC> strongThis(this);

Nit: why do you initialize this RefPtr with constructor syntax and the previous
ones with assignment?


More information about the webkit-reviews mailing list