[webkit-reviews] review granted: [Bug 132637] [Mac, iOS] Add source application accounting to AVURLAsset. : [Attachment 231088] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 132637: [Mac, iOS] Add source application accounting to AVURLAsset.
https://bugs.webkit.org/show_bug.cgi?id=132637

Attachment 231088: Patch
https://bugs.webkit.org/attachment.cgi?id=231088&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231088&action=review


> Source/WebCore/ChangeLog:8
> +	   Property account for the application responisble for data loading by
passing the source

Nit: Do you mean "Properly"?

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:154
> +SOFT_LINK_POINTER(AVFoundation, AVURLAssetClientBundleIdentifierKey,
NSString *)

Should you use SOFT_LINK_POINTER_OPTIONAL for older systems?