[webkit-reviews] review requested: [Bug 132697] Web Inspector: InspectorDOMAgent::getAccessibilityPropertiesForNode should gracefully handle bad node : [Attachment 231087] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 8 12:00:20 PDT 2014


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 132697: Web Inspector: InspectorDOMAgent::getAccessibilityPropertiesForNode
should gracefully handle bad node
https://bugs.webkit.org/show_bug.cgi?id=132697

Attachment 231087: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=231087&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
In release builds buildObjectForAccessibilityProperties would return nullptr.
In debug builds we would assert if we passed a null node to
buildObjectForAccessibilityProperties.
So more gracefully handle a null node before calling the function.


More information about the webkit-reviews mailing list