[webkit-reviews] review granted: [Bug 132112] Web Inspector: Selecting frame in debugger sidebar doesn't reveal code : [Attachment 231026] [PATCH] Proposed Fix: Addition of NavigationSidebar#isElementSelected getter

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Jono Wells
<jonowells at apple.com>'s request for review:
Bug 132112: Web Inspector: Selecting frame in debugger sidebar doesn't reveal
code
https://bugs.webkit.org/show_bug.cgi?id=132112

Attachment 231026: [PATCH] Proposed Fix: Addition of
NavigationSidebar#isElementSelected getter
https://bugs.webkit.org/attachment.cgi?id=231026&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231026&action=review


r=me with some comments

> Source/WebInspectorUI/ChangeLog:8
> +	   `WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar`
was checking

No need for all the backticks here.

> Source/WebInspectorUI/UserInterface/Base/Main.js:925
> +    if (!selectedSidebarPanel.elementIsSelected)

I think the name "elementIsSelected" is weird. Maybe "hasSelectedElement" or
"hasSelection"?

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:132
> +    get elementIsSelected() {

Style: Brace on newline.