[webkit-reviews] review granted: [Bug 124052] [CSS Shapes] Shapes do not resolve dimensions specified in viewport units : [Attachment 231028] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Bem Jones-Bey <bjonesbe at adobe.com>'s
request for review:
Bug 124052: [CSS Shapes] Shapes do not resolve dimensions specified in viewport
units
https://bugs.webkit.org/show_bug.cgi?id=124052

Attachment 231028: Patch
https://bugs.webkit.org/attachment.cgi?id=231028&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231028&action=review


r=me

> Source/WebCore/css/BasicShapeFunctions.cpp:268
> +float floatValueForCenterCoordinate(const BasicShapeCenterCoordinate&
center, float boxDimension, RenderView* view)

Can you use a reference instead of a pointer?

> Source/WebCore/css/BasicShapeFunctions.h:48
> +float floatValueForCenterCoordinate(const BasicShapeCenterCoordinate&,
float, RenderView*);

Ditto.

> Source/WebCore/css/LengthFunctions.h:41
> +FloatSize floatSizeForLengthSize(const LengthSize&, const FloatSize&,
RenderView* = 0);

Hm, ok.