[webkit-reviews] review denied: [Bug 132678] [EFL] Fix build error in blob.cpp after r168435 : [Attachment 231056] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Praveen Jadhav
<praveen.j at samsung.com>'s request for review:
Bug 132678: [EFL] Fix build error in blob.cpp after r168435
https://bugs.webkit.org/show_bug.cgi?id=132678

Attachment 231056: Patch
https://bugs.webkit.org/attachment.cgi?id=231056&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231056&action=review


Sorry for the breakage - efl-wk2 bot was green, and efl one does not work.

> Source/WebCore/fileapi/Blob.cpp:127
> -	   m_size = (actualSize <= std::numeric_limits<long long>::max()) ?
static_cast<long long>(actualSize) : 0;
> +	   m_size = (actualSize <= std::numeric_limits<unsigned long
long>::max()) ? static_cast<long long>(actualSize) : 0;

The purpose of this check is to verify that the number fits into long long - we
already know that it fits into an unsigned long long!

if it complains about signed/unsigned comparison, you probably need something
like

actualSize <= static_cast<unsigned long long>(std::numeric_limits<long
long>::max()))