[webkit-reviews] review granted: [Bug 132584] Add support for drawFocusIfNeeded : [Attachment 231062] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 8 06:51:18 PDT 2014


Dirk Schulze <krit at webkit.org> has granted Rik Cabanier <cabanier at adobe.com>'s
request for review:
Bug 132584: Add support for drawFocusIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=132584

Attachment 231062: Patch
https://bugs.webkit.org/attachment.cgi?id=231062&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231062&action=review


Snippet in changelog. Otherwise looks good to me. Please give Dean time to look
at it before landing.

> Source/WebCore/ChangeLog:8
> +	   This API will draw a focus ring if the element is focused.

"the element"? What kind of element? It is a child of <canvas>, right? And it
is also just drawn when the element is focused and the function is called.


More information about the webkit-reviews mailing list