[webkit-reviews] review granted: [Bug 132633] Dragging text from one paragraph to another does not render as expected : [Attachment 231035] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 7 19:44:49 PDT 2014
Ryosuke Niwa <rniwa at webkit.org> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 132633: Dragging text from one paragraph to another does not render as
expected
https://bugs.webkit.org/show_bug.cgi?id=132633
Attachment 231035: Patch
https://bugs.webkit.org/attachment.cgi?id=231035&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231035&action=review
> Source/WebCore/editing/ReplaceSelectionCommand.cpp:632
> + auto* paragraphElement =
enclosingElementWithTag(positionInParentBeforeNode(node.get()), pTag);
Put auto* ~ inside if () to limit the scope.
Basically, the first line doesn't need to change other than adding {.
More information about the webkit-reviews
mailing list