[webkit-reviews] review granted: [Bug 126022] [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load : [Attachment 230477] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 126022: [CoordinatedGraphics][WK2] Scale factor and scroll position is not
being restored properly in a back/forward load
https://bugs.webkit.org/show_bug.cgi?id=126022

Attachment 230477: Patch
https://bugs.webkit.org/attachment.cgi?id=230477&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
We should really get rid of TILED_BACKING_STORE.
OS X and iOS also have tiled backing store, TILED_BACKING_STORE is mostly
duplicated code at this point.

A quick grep for TILED_BACKING_STORE shows it is actually duplicating a lot of
features that have been upstreamed when iOS was upstreamed. In some cases, the
code behind TILED_BACKING_STORE looks very suspicious.
Now is not the right time though.

I have serious doubt this is patch correct. For example, the call to
Page::setPageScaleFactor() could come from WebPage::scalePage(), in which case
calling back into scroll requested does not make any sense.
I don't want to block you on this regression forever, the impact not any worse
than the other TILED_BACKING_STORE stuff  -> r+ for now.