[webkit-reviews] review denied: [Bug 132574] clean up ResourceLoadTiming : [Attachment 231004] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 132574: clean up ResourceLoadTiming
https://bugs.webkit.org/show_bug.cgi?id=132574

Attachment 231004: Patch
https://bugs.webkit.org/attachment.cgi?id=231004&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231004&action=review


Yes, the situation with monotonic times doesn't seem right. Discussing in
person.

>
Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelega
te.mm:220
> +#if __has_include(<CFNetwork/CFNSURLConnection.h>)
> +	   ResourceResponse resourceResponse(r);

Open source builds should not magically have the feature broken. What we should
do is re-declare _timingData as a category, and have the code under if
ENABLE(RESOURCE_TIMING).

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:806
> +    

Spurious whitespace!