[webkit-reviews] review granted: [Bug 132663] Image menu is offset by the amount the view is scrolled : [Attachment 231021] Patch v1

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 132663: Image menu is offset by the amount the view is scrolled
https://bugs.webkit.org/show_bug.cgi?id=132663

Attachment 231021: Patch v1
https://bugs.webkit.org/attachment.cgi?id=231021&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231021&action=review


> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:433
>      IntPoint point =
frameView->contentsToRootView(page->contextMenuController().hitTestResult().rou
ndedPointInInnerNodeFrame());
> +    point.moveBy(frameView->scrollPosition());

I think you want contentsToWindow instead of contentsToRootView, right? And
then you won't need to remove the scrollPosition yourself.