[webkit-reviews] review granted: [Bug 132506] HTMLMediaElement should exitFullscreen when view is removed from the window. : [Attachment 230880] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 132506: HTMLMediaElement should exitFullscreen when view is removed from
the window.
https://bugs.webkit.org/show_bug.cgi?id=132506

Attachment 230880: Patch
https://bugs.webkit.org/attachment.cgi?id=230880&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230880&action=review


WK2 part is fine with me, the rest has ericc's review.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1103
>  #endif
>  
> +#if PLATFORM(IOS)
> +    if ((mayHaveChanged & ViewState::IsInWindow) && !(m_viewState &
ViewState::IsInWindow)) {
> +	   // When leaving the current page, close the video fullscreen.
> +	   if (m_videoFullscreenManager)
> +	       m_videoFullscreenManager->requestExitFullscreen();
> +    }
> +#endif
> +
>      updateBackingStoreDiscardableState();

Merge these and put the #ifs inside the conditional, maybe?