[webkit-reviews] review denied: [Bug 132584] Add support for drawFocusIfNeeded : [Attachment 230863] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Rik Cabanier <cabanier at adobe.com>'s
request for review:
Bug 132584: Add support for drawFocusIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=132584

Attachment 230863: Patch
https://bugs.webkit.org/attachment.cgi?id=230863&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230863&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests.

Why are there no tests? Seems like it could be emulated, no?

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1969
> +void CanvasRenderingContext2D::drawFocusIfNeeded(Element* element)

It would definitely be great to have tests for that!

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1978
> +    if (element->focused()) {

Early return:
if (!element->focused())
    return;