[webkit-reviews] review requested: [Bug 132636] Add WK2 SPI to prevent the previous back/forward item from remaining in the list : [Attachment 230965] Patch v2 - Update to handle gotoitem, and hopefully keep builds working

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 132636: Add WK2 SPI to prevent the previous back/forward item from
remaining in the list
https://bugs.webkit.org/show_bug.cgi?id=132636

Attachment 230965: Patch v2 - Update to handle gotoitem, and hopefully keep
builds working
https://bugs.webkit.org/attachment.cgi?id=230965&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
This patch doesn't change the name/function of the SPI, per my previous
comments.

If you really think it should be a positive action instead of a negative
action, I don't mind that.

I just really dislike the name of the reason stated.

Maybe instead of "shouldAddCurrentBackForwardListItemFromList" it could be
"shouldKeepCurrentBackForwardListItemInList"?