[webkit-reviews] review granted: [Bug 131356] REGRESSION(r166678): Dromaeo/cssquery-dojo.html crashes regularly : [Attachment 230950] the patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 6 16:49:44 PDT 2014


Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 131356: REGRESSION(r166678): Dromaeo/cssquery-dojo.html crashes regularly
https://bugs.webkit.org/show_bug.cgi?id=131356

Attachment 230950: the patch.
https://bugs.webkit.org/attachment.cgi?id=230950&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230950&action=review


r=me

> Source/JavaScriptCore/bytecode/VariableWatchpointSet.h:82
> +    SymbolTable* m_symbolTable;

Since this pointer is never null, and available at initialization time, it
should be a reference.


More information about the webkit-reviews mailing list