[webkit-reviews] review granted: [Bug 132579] Don't select an image that is about to have its menu shown. : [Attachment 230911] Patch v1

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 132579: Don't select an image that is about to have its menu shown.
https://bugs.webkit.org/show_bug.cgi?id=132579

Attachment 230911: Patch v1
https://bugs.webkit.org/attachment.cgi?id=230911&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230911&action=review


> Source/WebCore/editing/mac/EditorMac.mm:272
> +    if (&(node->document()) != m_frame.document())

Don't think you need the parens.

> Source/WebKit/mac/ChangeLog:10
> +	     Call the new replaceNodeFromPasteboard API instead of
readSelectionFromPasteboard.

extra space at the beginning of the line

> Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:125
> +    Node* node =
page->contextMenuController().context().hitTestResult().innerNode();
> +    if (node) {

if (Node* node = ...)