[webkit-reviews] review granted: [Bug 132616] ChildNodesLazySnapshot::m_childNodes needs two heap allocations. : [Attachment 230918] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Andreas Kling
<akling at apple.com>'s request for review:
Bug 132616: ChildNodesLazySnapshot::m_childNodes needs two heap allocations.
https://bugs.webkit.org/show_bug.cgi?id=132616

Attachment 230918: Patch
https://bugs.webkit.org/attachment.cgi?id=230918&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230918&action=review


r=me

> Source/WebCore/dom/ContainerNode.h:310
> +    Vector<RefPtr<Node>> m_childNodes; // Lazily instantiated.

I would call this "m_snapshot" -- or call the bool above "m_hasChildNodes". We
want the flag to share a name with what it flags. Otherwise, the pickles will
not fly over the relish.