[webkit-reviews] review denied: [Bug 132558] [MediaStream] MediaStream.addTrack Should not check for active state. : [Attachment 230808] MediaStream.addTrack method is checking for active state of a MediaStream, but it should not check for active state while adding a Track.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 6 10:34:30 PDT 2014


Eric Carlson <eric.carlson at apple.com> has denied Kiran
<kiran.guduru at samsung.com>'s request for review:
Bug 132558: [MediaStream] MediaStream.addTrack Should not check for active
state.
https://bugs.webkit.org/show_bug.cgi?id=132558

Attachment 230808: MediaStream.addTrack method is checking for active state of
a MediaStream, but it should not check for active state while adding a Track.
https://bugs.webkit.org/attachment.cgi?id=230808&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230808&action=review


> Source/WebCore/ChangeLog:11
> +	   No new tests, no behavior change.

This is incorrect, you note the need for a behavior change in the bug: "Create
a MediaStream without any argument, then try to add tracks to the newly created
mediaStream". 

It sounds like it should be easy to create a test case for this change.


More information about the webkit-reviews mailing list